refactor: rename Checkout prefixed types ShopifyCheckout #401
+74
−76
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
|
kieran-osgood-shopify
force-pushed
the
refactor/rename-checkout-shopifycheckout
branch
from
9746f20 to
dcdd1a7
Compare
kieran-osgood-shopify
changed the base branch from
prototype/development
to
feat/expose-checkoutoptions-present
kieran-osgood-shopify
force-pushed
the
feat/expose-checkoutoptions-present
branch
from
2011853 to
bbcc33e
Compare
Base automatically changed from
feat/expose-checkoutoptions-present
to
prototype/development
November 28, 2025 17:54
kieran-osgood-shopify
force-pushed
the
refactor/rename-checkout-shopifycheckout
branch
from
dcdd1a7 to
951c103
Compare
Contributor
Author
There was a problem hiding this comment.
this was not caught in CI by mistake but is superceded/implemented properly in #398
| ]) | ||
| } | ||
|
|
||
| func checkoutDidRequestCardChange(event: CheckoutCardChangeRequested) { |
Juanita-Dash
approved these changes
Nov 28, 2025
Juanita-Dash
left a comment
Juanita-Dash
left a comment
There was a problem hiding this comment.
Left 1 clarifying question. Looks good otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes are you making?
PR Checklist
Important
Releasing a new version of the kit?
package.jsonfile.Tip
See the Contributing documentation for instructions on how to publish a new version of the library.